mrumel/Dell_iDRAC_fan_controller_Docker
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cant start env variable with numbers

Browse source
This commit is contained in:
Sean Cline 2024-11-10 20:28:10 +01:00 • committed by Tigerblue77
parent 9fbcd12a49
commit ec364b009b
3 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Dockerfile
View file

@ -21,7 +21,7 @@ HEALTHCHECK --interval=30s --timeout=30s --start-period=5s --retries=3 CMD [ "/a
ENV IDRAC_HOST local
# ENV IDRAC_USERNAME root
# ENV IDRAC_PASSWORD calvin
ENV 14_GEN false
ENV DELL_14_GEN false
ENV FAN_SPEED 5
ENV CPU_TEMPERATURE_THRESHOLD 50
ENV CHECK_INTERVAL 60

2
README.md
View file

@ -162,7 +162,7 @@ All parameters are optional as they have default values (including default iDRAC
- `CHECK_INTERVAL` parameter is the time (in seconds) between each temperature check and potential profile change. **Default** value is 60(s).
- `DISABLE_THIRD_PARTY_PCIE_CARD_DELL_DEFAULT_COOLING_RESPONSE` parameter is a boolean that allows to disable third-party PCIe card Dell default cooling response. **Default** value is false.
- `KEEP_THIRD_PARTY_PCIE_CARD_COOLING_RESPONSE_STATE_ON_EXIT` parameter is a boolean that allows to keep the third-party PCIe card Dell default cooling response state upon exit. **Default** value is false, so that it resets the third-party PCIe card Dell default cooling response to Dell default.
- `14_GEN` parameter that disabled 3rd party PCI calls and outputs CPU temperatures correctly for 14th Gen Dell servers, ex Dell r640, 740 series. Must have idrac 3.30.30.30 or older. **Default** value is false.
- `DELL_14_GEN` parameter that disabled 3rd party PCI calls and outputs CPU temperatures correctly for 14th Gen Dell servers, ex Dell r640, 740 series. Must have idrac 3.30.30.30 or older. **Default** value is false.
<p align="right">(<a href="#top">back to top</a>)</p>

8
functions.sh
View file

@ -38,7 +38,7 @@ function retrieve_temperatures () {
# Parse CPU data
local CPU_DATA=$(echo "$DATA" | grep "3\." | grep -Po '\d{2}')
if $14_GEN
if $DELL_14_GEN
then
# 14 Gen server or newer
CPU1_TEMPERATURE=$(echo $CPU_DATA | awk '{print $2;}')
@ -48,7 +48,7 @@ function retrieve_temperatures () {
fi
if $IS_CPU2_TEMPERATURE_SENSOR_PRESENT
then
if $14_GEN
if $DELL_14_GEN
then
# 14 Gen server or newer
CPU2_TEMPERATURE=$(echo $CPU_DATA | awk '{print $4;}')
@ -74,7 +74,7 @@ function retrieve_temperatures () {
function enable_third_party_PCIe_card_Dell_default_cooling_response () {
# We could check the current cooling response before applying but it's not very useful so let's skip the test and apply directly
if $14_GEN
if $DELL_14_GEN
then
# 14 Gen server or newer
continue
@ -86,7 +86,7 @@ function enable_third_party_PCIe_card_Dell_default_cooling_response () {
function disable_third_party_PCIe_card_Dell_default_cooling_response () {
# We could check the current cooling response before applying but it's not very useful so let's skip the test and apply directly
if $14_GEN
if $DELL_14_GEN
then
# 14 Gen server or newer
continue